Conversation
|
Ah, nice! Some, if not many, of those are old relics from when Rust was different... Nice to see them being found and cleaned out. I guess I should start checking with Clippy from time to time. Some of the remaining ones are most likely necessary or doesn't really matter, but at least the last once about |
|
I wasn't sure about that one since it changes some public interface. |
|
No, that one is safe to change. I have hidden it from the docs and written a warning. |
|
The tests are nice and green. Thank you! @homu r+ |
|
📌 Commit 7986f31 has been approved by |
Cleanup some warnings from Clippy For information, [here is the log before and after](https://gist.github.com/mcarton/6411c8526dee7b12632b) with Clippy. Remaining warnings from Clippy are mostly false positive.
|
⚡ Test exempted - status |
For information, here is the log before and after with Clippy.
Remaining warnings from Clippy are mostly false positive.